Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-168: Add newline to end of page #173

Merged
merged 1 commit into from
Dec 23, 2014
Merged

GH-168: Add newline to end of page #173

merged 1 commit into from
Dec 23, 2014

Conversation

msabramo
Copy link
Contributor

Fixes GH-168

Before:
❯ curl http://127.0.0.1:8080/get
{
  "args": {},
  "headers": {
    "Accept": "*/*",
    "Host": "127.0.0.1:8080",
    "User-Agent": "curl/7.30.0"
  },
  "origin": "127.0.0.1",
  "url": "http://127.0.0.1:8080/get"
}%

The % at the end indicates the lack of a trailing newline.

After:
❯ curl http://127.0.0.1:8080/get
{
  "args": {},
  "headers": {
    "Accept": "*/*",
    "Host": "127.0.0.1:8080",
    "User-Agent": "curl/7.30.0"
  },
  "origin": "127.0.0.1",
  "url": "http://127.0.0.1:8080/get"
}

I also submitted a PR to Flask for this issue: pallets/flask#1262

@frankstratton
Copy link
Contributor

👍

@johnsheehan
Copy link
Contributor

i can merge this in if you can bring it up to master

@msabramo
Copy link
Contributor Author

i can merge this in if you can bring it up to master

Done.

$ git push -f msabramo GH-168
Counting objects: 61, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (61/61), done.
Writing objects: 100% (61/61), 8.08 KiB | 0 bytes/s, done.
Total 61 (delta 41), reused 0 (delta 0)
To git@github.com:msabramo/httpbin.git
 + d8ad1d4...24dadf0 GH-168 -> GH-168 (forced update)

@johnsheehan johnsheehan merged commit 24dadf0 into postmanlabs:master Dec 23, 2014
@johnsheehan
Copy link
Contributor

deploying now

@jeroen
Copy link
Contributor

jeroen commented Dec 23, 2014

Sweet

@msabramo msabramo deleted the GH-168 branch December 23, 2014 00:28
@nateprewitt nateprewitt mentioned this pull request Jan 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add newline to end of page
4 participants
@msabramo @frankstratton @johnsheehan @jeroen